Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple adapters from core #8666

Closed
wants to merge 5 commits into from
Closed

Decouple adapters from core #8666

wants to merge 5 commits into from

Conversation

MichelleArk
Copy link
Contributor

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (98310b6) 86.31% compared to head (5fcd2b8) 86.47%.

❗ Current head 5fcd2b8 differs from pull request most recent head 699fba8. Consider uploading reports for the commit 699fba8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8666      +/-   ##
==========================================
+ Coverage   86.31%   86.47%   +0.15%     
==========================================
  Files         177      181       +4     
  Lines       26385    25690     -695     
==========================================
- Hits        22775    22216     -559     
+ Misses       3610     3474     -136
Flag Coverage Δ
integration 83.26% <77.77%> (+0.16%) ⬆️
unit 65.06% <77.77%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/adapters/base/__init__.py 100.00% <100.00%> (ø)
core/dbt/adapters/base/connections.py 89.24% <100.00%> (ø)
core/dbt/adapters/base/query_headers.py 98.41% <100.00%> (ø)
core/dbt/adapters/contracts/connection.py 96.06% <100.00%> (ø)
core/dbt/adapters/factory.py 91.89% <100.00%> (ø)
core/dbt/adapters/protocol.py 70.58% <100.00%> (ø)
...ore/dbt/adapters/relation_configs/config_change.py 94.11% <100.00%> (ø)
core/dbt/adapters/sql/connections.py 95.91% <100.00%> (+1.02%) ⬆️
core/dbt/adapters/sql/impl.py 93.33% <100.00%> (ø)
core/dbt/common/constants.py 100.00% <100.00%> (ø)
... and 49 more

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colin-rogers-dbt @peterallenwebb
Move events to common (#8676)
29f734d 
* Move events to common

* More Type Annotations (#8536)

* Extend use of type annotations in the events module.

* Add return type of None to more __init__ definitions.

* Still more type annotations adding -> None to __init__

* Tweak per review

* Allow adapters to include python package logging in dbt logs (#8643)

* add set_package_log_level functionality

* set package handler

* set package handler

* add logging about stting up logging

* test event log handler

* add event log handler

* add event log level

* rename package and add unit tests

* revert logfile config change

* cleanup and add code comments

* add changie

* swap function for dict

* add additional unit tests

* fix unit test

* update README and protos

* fix formatting

* update precommit

---------

Co-authored-by: Peter Webb <[email protected]>
@MichelleArk MichelleArk changed the title remove dbt.contracts.connection imports from adapter module Decouple adapters from core Oct 25, 2023
@MichelleArk
Copy link
Contributor Author

Closing in favor of: #8906

@MichelleArk MichelleArk closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelleArk @colin-rogers-dbt